vanzin commented on a change in pull request #48: [LIVY-41] Let users access sessions by session name URL: https://github.com/apache/incubator-livy/pull/48#discussion_r251978628
########## File path: server/src/test/scala/org/apache/livy/server/interactive/InteractiveSessionServletSpec.scala ########## @@ -177,6 +180,45 @@ class InteractiveSessionServletSpec extends BaseInteractiveServletSpec { .asInstanceOf[SessionInfo] view.id shouldEqual id + view.name shouldEqual name + view.appId shouldEqual appId + view.owner shouldEqual owner + view.proxyUser shouldEqual proxyUser + view.state shouldEqual state.toString + view.kind shouldEqual kind.toString + view.appInfo should contain (Entry(AppInfo.DRIVER_LOG_URL_NAME, appInfo.driverLogUrl.get)) + view.appInfo should contain (Entry(AppInfo.SPARK_UI_URL_NAME, appInfo.sparkUiUrl.get)) + view.log shouldEqual log.asJava + } + + it("should show session properties for sessions without a name") { Review comment: Same thing here. Better to avoid copy & pasting the existing test and changing a couple of lines. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services