meisam commented on a change in pull request #48: [LIVY-41] Let users access
sessions by session name
URL: https://github.com/apache/incubator-livy/pull/48#discussion_r252071059
##########
File path: server/src/main/scala/org/apache/livy/sessions/Session.scala
##########
@@ -135,13 +134,25 @@ object Session {
}
}
-abstract class Session(val id: Int, val owner: String, val livyConf: LivyConf)
+abstract class Session(
+ val id: Int,
+ val name: Option[String],
+ val owner: String,
+ val livyConf: LivyConf)
extends Logging {
import Session._
protected implicit val executionContext = ExecutionContext.global
+ private def isSessionId(str: String): Boolean = {
+ str.nonEmpty && str.forall(_.isDigit)
+ }
+
+ name.foreach { idStr =>
Review comment:
renamed it to sessionName
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
