mgaido91 commented on a change in pull request #162: [LIVY-572] Avoid usage of
spark classes in ColumnBuffer
URL: https://github.com/apache/incubator-livy/pull/162#discussion_r268953090
##########
File path:
thriftserver/session/src/main/java/org/apache/livy/thriftserver/session/ResultSet.java
##########
@@ -43,7 +63,13 @@ public void addRow(Object[] fields) {
}
for (int i = 0; i < fields.length; i++) {
- columns[i].add(fields[i]);
+ Object value;
+ if (columnIsString[i]) {
Review comment:
Yes, the reason why I did so was to avoid doing the check for every field of
each row and hence avoid introducing an overhead in a part of the code which is
critical for performances. Anyway, if you feel strong about this I can change
it: it is also true that the overhead is probably very small compared to all
the operations which we need to perform, e.g. transfer the data over the
network...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
