ajbozarth commented on a change in pull request #188: LIVY-615: Set context
path using property SERVER_BASE_PATH.
URL: https://github.com/apache/incubator-livy/pull/188#discussion_r309886266
##########
File path: server/src/main/scala/org/apache/livy/server/WebServer.scala
##########
@@ -81,7 +81,10 @@ class WebServer(livyConf: LivyConf, var host: String, var
port: Int) extends Log
val context = new ServletContextHandler()
- context.setContextPath("/")
+ private val contextPath = "/" +
livyConf.get(LivyConf.SERVER_BASE_PATH).stripPrefix("/")
Review comment:
As a follow up I read through the original PR and both this and its JIRAs to
trace the intention, implementation, conversations, etc. Based on the original
PR conversation I believe this PR does what the original author intended. I
believe @jerryshao and myself misunderstood the author's intention previously
and thus missed the necessity of this extra bit of code. With this in mind I'll
do a proper code review of this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
