fdeantoni commented on a change in pull request #188: LIVY-615: Set context
path using property SERVER_BASE_PATH.
URL: https://github.com/apache/incubator-livy/pull/188#discussion_r309953116
##########
File path: server/src/main/scala/org/apache/livy/LivyConf.scala
##########
@@ -60,7 +60,7 @@ object LivyConf {
val SERVER_HOST = Entry("livy.server.host", "0.0.0.0")
val SERVER_PORT = Entry("livy.server.port", 8998)
- val SERVER_BASE_PATH = Entry("livy.ui.basePath", "")
+ val SERVER_BASE_PATH = Entry("livy.ui.basePath", "/")
Review comment:
I agree, it will be much clearer to the user what the intent is. The old
property can simply reference the new `livy.server.basePath` property to make
it backwards compatible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
