jerryshao commented on a change in pull request #197: [LIVY-574][THRIFT
SERVER][TEST] Add tests for metadata operations
URL: https://github.com/apache/incubator-livy/pull/197#discussion_r315025250
##########
File path:
thriftserver/server/src/main/scala/org/apache/livy/thriftserver/operation/MetadataOperation.scala
##########
@@ -42,8 +46,14 @@ abstract class MetadataOperation(sessionHandle:
SessionHandle, opType: Operation
assertState(Seq(OperationState.FINISHED))
validateFetchOrientation(orientation)
if (orientation.equals(FetchOrientation.FETCH_FIRST)) {
- rowSet.setRowOffset(0)
+ offset = 0
+ }
+
+ if (offset >= rowSet.numRows) {
Review comment:
What's the pros and cons of these two methods?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
