captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for
ThriftServer
URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319413752
##########
File path:
thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala
##########
@@ -259,6 +263,171 @@ trait CommonThriftTests {
class BinaryThriftServerSuite extends ThriftServerBaseTest with
CommonThriftTests {
override def mode: ServerMode.Value = ServerMode.binary
override def port: Int = 20000
+ // In BinaryThriftServerSuite, we set ENABLE_HIVE_CONTEXT=true to support
the creation
+ // of Hive tables.
+ livyConf.set(LivyConf.ENABLE_HIVE_CONTEXT, true)
+
+ def getTestDataFilePath(): URL = {
+
Thread.currentThread().getContextClassLoader.getResource("data/files/small_kv.txt")
+ }
+
+ test("result set containing NULL") {
Review comment:
And there is a overlap here with the dataTypesTest. I'm going to delete this
test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
