o-shevchenko commented on a change in pull request #220: [LIVY-654] Ability to 
validate string before creating state/kind of session/statement
URL: https://github.com/apache/incubator-livy/pull/220#discussion_r319847072
 
 

 ##########
 File path: core/src/main/scala/org/apache/livy/sessions/Kind.scala
 ##########
 @@ -45,6 +45,12 @@ object Kind {
     case "sql" => SQL
     case other => throw new IllegalArgumentException(s"Invalid kind: $other")
   }
+
+  val kinds: Seq[Kind] = Seq(Spark, PySpark, SparkR, Shared, SQL)
+
+  def isValid(kind: String): Boolean = {
 
 Review comment:
   to verify that we can create StateSession object from a string without 
additional logic for catching exceptions.
   There is the example in the description.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to