jerryshao commented on a change in pull request #224: [LIVY-633][Server] 
session should not be gc-ed for long running queries
URL: https://github.com/apache/incubator-livy/pull/224#discussion_r321098795
 
 

 ##########
 File path: rsc/src/main/java/org/apache/livy/rsc/RSCClient.java
 ##########
 @@ -411,6 +425,10 @@ private void handle(ChannelHandlerContext ctx, JobStarted 
msg) {
 
     private void handle(ChannelHandlerContext ctx, ReplState msg) {
       LOG.trace("Received repl state for {}", msg.state);
+      // Update last activity timestamp when there's state change.
+      if (replState == null || !replState.equals(msg.state)) {
 
 Review comment:
   Shall we only track the state from `busy` to others? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to