jerryshao commented on a change in pull request #225: [LIVY-657]Fix travis 
failed on should not create sessions with duplicate names
URL: https://github.com/apache/incubator-livy/pull/225#discussion_r321090816
 
 

 ##########
 File path: 
server/src/test/scala/org/apache/livy/sessions/SessionManagerSpec.scala
 ##########
 @@ -92,6 +94,7 @@ class SessionManagerSpec extends FunSpec with Matchers with 
LivyBaseUnitTestSuit
       an[IllegalArgumentException] should be thrownBy 
manager.register(session2)
       manager.get(session1.id).isDefined should be(true)
       manager.get(session2.id).isDefined should be(false)
+      Utils.waitUntil({ () => session2.stopped }, Duration(10, 
TimeUnit.SECONDS))
 
 Review comment:
   I think we can  scalatest's `Eventually` for such waiting test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to