yantzu commented on issue #223: [LIVY-658]RSCDriver should catch exception if 
cancel job failed during shutdown
URL: https://github.com/apache/incubator-livy/pull/223#issuecomment-528250103
   The unit test I add demonstrate how NullPointerException happens: a request 
send to RSCDriver while it is initializing, after initialization failed, 
RSCDriver try to cancel job. In real case, it is beeline send a "use default" 
SQL to thrift server then RSCDriver. 
   I think it is possible to avoid NPE in this case, but not sure if it is what 
we should do, because:
   1, there may be other reason cause cancel job failure, to fix all those 
would be diffcult
   2, catch and log exception when cancel job give RSCDriver a chance to cancel 
other job and shutdown context correctly
   3, RSCDriver already catch shutdownContext() and shutdownServer() call

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

Reply via email to