mgaido91 commented on a change in pull request #195: [LIVY-634] To support 
reuse hive PasswdAuthenticationProvider implementation in ThriftServer
URL: https://github.com/apache/incubator-livy/pull/195#discussion_r322722547
 
 

 ##########
 File path: thriftserver/server/pom.xml
 ##########
 @@ -56,6 +56,25 @@
         </exclusion>
       </exclusions>
     </dependency>
+    <dependency>
+      <groupId>org.apache.hive</groupId>
+      <artifactId>hive-common</artifactId>
 
 Review comment:
   > implement all of them is a huge work
   yes, I am aware. That's why in the original implementation this was left out 
for future work.
   The approach in #183 is the right one IMO. We might also accept not to have 
all the functionalities Hive has for starting, but we need to clearly clarify 
the differences and to have an implementation which can be extended later to 
have the same functionalities.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to