captainzmc commented on a change in pull request #231: [LIVY-356][SERVER]Add 
LDAP authentication for livy-server.
URL: https://github.com/apache/incubator-livy/pull/231#discussion_r325143141
 
 

 ##########
 File path: server/src/main/scala/org/apache/livy/server/LivyServer.scala
 ##########
 @@ -260,6 +261,26 @@ class LivyServer extends Logging {
         server.context.addFilter(holder, "/*", 
EnumSet.allOf(classOf[DispatcherType]))
         info(s"SPNEGO auth enabled (principal = $principal)")
 
+      case authType @ LdapAuthenticationHandlerImpl.TYPE =>
 
 Review comment:
   Sorry for not adding JIRA in title. This part is to add ldap authentication 
in livy-server (rest). The authentication unification in rest before referred 
to hadoop's filters, so this part is consistent.
   Now I am currently working on ldap authentication in thrift-server (not yet 
complete) and refer to this PR #183 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to