captainzmc commented on a change in pull request #231: [LIVY-356][SERVER]Add 
LDAP authentication for livy-server.
URL: https://github.com/apache/incubator-livy/pull/231#discussion_r325146353
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -121,6 +121,10 @@
     <!-- Set this to "true" to skip PySpark3 tests. -->
     <skipPySpark3Tests>false</skipPySpark3Tests>
 
+    <!-- Required for testing LDAP integration -->
 
 Review comment:
   This section is for testing only, and needs to simulate a Mini ldap 
environment, with reference to 
[hadoop](https://github.com/apache/hadoop/blob/release-2.8.0-RC0/hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/server/TestLdapAuthenticationHandler.java)
 and 
[hive](https://github.com/apache/hive/blob/master/service/src/test/org/apache/hive/service/auth/TestLdapAtnProviderWithMiniDS.java)
 practices

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to