yiheng commented on a change in pull request #103: [LIVY-239] Generate session 
IDs in SessionStore, not in SessionManager
URL: https://github.com/apache/incubator-livy/pull/103#discussion_r325526444
 
 

 ##########
 File path: 
server/src/main/scala/org/apache/livy/server/recovery/BlackholeStateStore.scala
 ##########
 @@ -26,11 +28,16 @@ import org.apache.livy.LivyConf
  * Livy will use this when session recovery is disabled.
  */
 class BlackholeStateStore(livyConf: LivyConf) extends StateStore(livyConf) {
+
+  private val atomicLong: AtomicLong = new AtomicLong(-1L)
 
 Review comment:
   Looks like this cannot guarantee the global uniqueness across many Livy 
services, right? As the `atomicLong` cannot be shared by processes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to