yiheng commented on a change in pull request #103: [LIVY-239] Generate session 
IDs in SessionStore, not in SessionManager
URL: https://github.com/apache/incubator-livy/pull/103#discussion_r325527127
 
 

 ##########
 File path: 
server/src/main/scala/org/apache/livy/server/recovery/FileSystemStateStore.scala
 ##########
 @@ -129,4 +129,10 @@ class FileSystemStateStore(
   }
 
   private def absPath(key: String): Path = new Path(fsUri.getPath(), key)
+
+  override def nextValue(key: String): Long = synchronized {
+    val incrementedValue = 1 + get[Long](key).getOrElse(-1L)
 
 Review comment:
   Is the `get` or `set` method atomic?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to