yiheng commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server. URL: https://github.com/apache/incubator-livy/pull/231#discussion_r328462885
########## File path: server/src/main/scala/org/apache/livy/server/auth/LdapAuthenticationHandlerImpl.scala ########## @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.livy.server.auth + +import java.io.IOException +import java.nio.charset.StandardCharsets +import java.util +import java.util.Properties +import javax.naming.NamingException +import javax.naming.directory.InitialDirContext +import javax.naming.ldap.{Control, InitialLdapContext, StartTlsRequest, StartTlsResponse} +import javax.net.ssl.{HostnameVerifier, SSLSession} +import javax.servlet.ServletException +import javax.servlet.http.{HttpServletRequest, HttpServletResponse} + +import org.apache.commons.codec.binary.Base64 +import org.apache.hadoop.security.authentication.client.AuthenticationException +import org.apache.hadoop.security.authentication.server.{AuthenticationHandler, AuthenticationToken} + +import org.apache.livy._ + +object LdapAuthenticationHandlerImpl { + + val AUTHORIZATION_SCHEME = "Basic" + val TYPE = "ldap" + val SECURITY_AUTHENTICATION = "simple" + val PROVIDER_URL = "ldap.providerurl" + val BASE_DN = "ldap.basedn" + val LDAP_BIND_DOMAIN = "ldap.binddomain" + val ENABLE_START_TLS = "ldap.enablestarttls" + + private def hasDomain(userName: String): Boolean = { + indexOfDomainMatch(userName) > 0 + } + + /** Review comment: should we use the java style java doc? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
