jerryshao commented on a change in pull request #237: [LIVY-688] Error message
of BypassJobStatus should contains cause information of Exception
URL: https://github.com/apache/incubator-livy/pull/237#discussion_r329334431
##########
File path: rsc/src/main/java/org/apache/livy/rsc/Utils.java
##########
@@ -91,13 +92,7 @@ public static String join(Iterable<String> strs, String
sep) {
}
public static String stackTraceAsString(Throwable t) {
- StringBuilder sb = new StringBuilder();
- sb.append(t.getClass().getName()).append(": ").append(t.getMessage());
- for (StackTraceElement e : t.getStackTrace()) {
- sb.append("\n");
- sb.append(e.toString());
- }
- return sb.toString();
+ return Throwables.getStackTraceAsString(t);
Review comment:
Would you please change to not use Guava? We removed the Guava support in
Livy server side, and if this method will be used in server side in future,
this will potentially cause some issues. CC @runzhiwang .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
