runzhiwang commented on a change in pull request #235: [LIVY-666] Support named
interpreter groups
URL: https://github.com/apache/incubator-livy/pull/235#discussion_r332295880
##########
File path: repl/src/main/scala/org/apache/livy/repl/Session.scala
##########
@@ -91,29 +95,42 @@ class Session(
entries.sc().sc
}
- private[repl] def interpreter(kind: Kind): Option[Interpreter] =
interpGroup.synchronized {
- if (interpGroup.contains(kind)) {
- Some(interpGroup(kind))
+ private[repl] def interpreter(kind: Kind, interpreterGroupKey: String =
Review comment:
why not` interpreterGroupKey: Option[String] = None` in param? and replace
101 to 105 with `val key =
interpreterGroupKey.getOrElse(DEFAULT_INTERPRETER_GROUP_KEY)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
