huianyi commented on a change in pull request #238: [LIVY-689] Deliver stage process message to the end user using thriftserver URL: https://github.com/apache/incubator-livy/pull/238#discussion_r333368731
########## File path: core/src/main/scala/org/apache/livy/OperationMessageManager.scala ########## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.livy + +object OperationMessageManager extends Logging{ + + def offer(message: Any): Unit = { + if (threadLocalLogQueue.get() != null){ + threadLocalLogQueue.get().offer(message.toString) + } + } + + def get(): ConcurrentBoundedLinkedQueue[String] = { + threadLocalLogQueue.get() + } + + def set(threadLocalLogQueue: ConcurrentBoundedLinkedQueue[String]){ + this.threadLocalLogQueue.set(threadLocalLogQueue) + } + private val threadLocalLogQueue = new ThreadLocal[ConcurrentBoundedLinkedQueue[String]] Review comment: Using this threadLocal variable gives us an easy way to get operationMessage object in other classes, we do not need transfer it in other classes. For example, Class ClientProtocol need operationMessage to deliver process message to the end user, we can just call `OperationMessageManager.get()` to get it. ```java private final ConcurrentBoundedLinkedQueue<String> operationMessages = OperationMessageManager.get(); ``` I don't think this might be reused for another rpc client, ConcurrentBoundedLinkedQueue would be initialized in `LivyThriftSessionManager.openSession` method, for every new session, we will create only one RSCClient for it, and both of them are in the same thread, so for every RSCClient, they will have the right ConcurrentBoundedLinkedQueue. Please correct me if I miss something. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
