mgaido91 commented on a change in pull request #236: [LIVY-678] Thrift ldap 
authentication, based on ldapurl, basedn, domain
URL: https://github.com/apache/incubator-livy/pull/236#discussion_r334232673
 
 

 ##########
 File path: 
thriftserver/server/src/main/scala/org/apache/livy/thriftserver/auth/LdapAuthenticationProviderImpl.scala
 ##########
 @@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.livy.thriftserver.auth
+
+import javax.security.sasl.AuthenticationException
+
+import org.apache.commons.lang.StringUtils
+import org.apache.hive.service.auth.PasswdAuthenticationProvider
+
+import org.apache.livy.thriftserver.auth.ldap._
+import org.apache.livy.LivyConf
+
+object LdapAuthenticationProviderImpl {
+
+  /**
+   * Initialize the Chain Filter List. Now GroupFilter is not supported.
+   * If needed, GroupFilter can be added in this list.
+   */
+  private def createFilters(conf: LivyConf): Filter = {
+    new ChainFilter(List(new UserFilter(conf)))
+  }
+}
+
+class LdapAuthenticationProviderImpl(val conf: LivyConf) extends 
PasswdAuthenticationProvider {
+  final private val filter: Filter = 
LdapAuthenticationProviderImpl.createFilters(conf)
+  final private val searchFactory: DirSearchFactory = new LdapSearchFactory()
+
+  @throws[AuthenticationException]
+  def Authenticate(user: String, password: String): Unit = {
+    createDirSearch(user, password)
+    applyFilter(user)
+  }
+
+  @throws[AuthenticationException]
+  private def createDirSearch(user: String, password: String): Unit = {
+    if (StringUtils.isBlank(user) || StringUtils.isEmpty(user)) {
+      throw new AuthenticationException(
+        "Error validating LDAP: a null or blank user name has been provided")
+    }
+    if (StringUtils.isBlank(password) || StringUtils.isEmpty(password)) {
+      throw new AuthenticationException(
+        "Error validating LDAP: a null or blank password has been provided")
+    }
+    val principal = LdapUtils.createCandidatePrincipal(conf, user)
+    try {
+      searchFactory.getInstance(conf, principal, password)
+    } catch {
+      case e: AuthenticationException =>
+        throw new AuthenticationException(
+          s"Error validating LDAP user: $user", e)
 
 Review comment:
   nit: on the line above?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to