captainzmc commented on a change in pull request #236: [LIVY-678] Thrift ldap
authentication, based on ldapurl, basedn, domain
URL: https://github.com/apache/incubator-livy/pull/236#discussion_r336999094
##########
File path: server/src/main/scala/org/apache/livy/LivyConf.scala
##########
@@ -167,7 +167,13 @@ object LivyConf {
Entry("livy.server.thrift.delegation.token.max-lifetime", "7d")
val THRIFT_DELEGATION_TOKEN_RENEW_INTERVAL =
Entry("livy.server.thrift.delegation.token.renew-interval", "1d")
-
+ val THRIFT_LDAP_AUTHENTICATION_URL =
Entry("livy.server.thrift.ldap.authentication.url", null)
+ val THRIFT_LDAP_AUTHENTICATION_BASEDN =
Review comment:
Hi @mgaido91 @jerryshao
Should we unify the configurations here? there will be configuration
differences, such as：
livy.server.thrift.authentication can be NOSASL while livy.server.auth.type
cannot be NOSASL.
thrift.ldap.authentication has userfilter while server.thrift.authentication
hasn‘t.
What should we do about the situation above？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
