huianyi edited a comment on issue #238: [LIVY-689] Deliver stage process 
message to the end user using thriftserver
URL: https://github.com/apache/incubator-livy/pull/238#issuecomment-545715699
 
 
   > > Rethink about the way this ticket doing, I think current way may not be 
the best way.
   > > 
   > > 1. `jobId` may not exactly match the currently running jobs, there's no 
issue for beeline, but could be an issue for multi-thread usage. Currently when 
getting active jobs, there's no direct relation to jobId.
   > > 2. There's already a way to calculate job progress in ReplDriver for 
statement, we should extend the current way to also apply to job API.
   > > 3. Using LivyServer to store the session/job status may not be fault 
tolerant. It would better to extend the job API to get job progress 
synchronously.
   > 
   > Thanks for your reply, if I have understood your meaning correctly, 
actually I can use `jobId`(which is spark jobs' group id delivered by livy) in 
`handleProcessMessage` method of RSCDriver, then get related stages using this 
`jobId`, to handle these circumstances above. May this be a good way?
   
   @jerryshao After a deep dive into this implement, I find it is difficult to 
get job group id from RSCDriver, at first I thought `jobId` might be the spark 
job group id(because in JobWrapper class, it calls setting JobGroup with 
`jobId`), actually I'm wrong. Spark JobGroup is set as SqlJob's statementId, 
and if I want to get this statementId in JobWrapper or RscDriver, I must 
convert JobWrapper's Job to SqlJob, this needs SqlJob's definition, as SqlJob 
is in thriftserver module, importing its definition in rsc module may not be a 
good way. Could you please give me some advice?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to