jerryshao commented on a change in pull request #274: [LIVY-721][SERVER]
Distributed session id generation
URL: https://github.com/apache/incubator-livy/pull/274#discussion_r375038954
##########
File path:
server/src/test/scala/org/apache/livy/sessions/SessionManagerSpec.scala
##########
@@ -271,17 +272,61 @@ class SessionManagerSpec extends FunSpec with Matchers
with LivyBaseUnitTestSuit
it("should not delete sessions on shutdown with recovery is on") {
val conf = new LivyConf()
- conf.set(LivyConf.RECOVERY_MODE,
SessionManager.SESSION_RECOVERY_MODE_RECOVERY)
+ conf.set(LivyConf.RECOVERY_MODE, LivyConf.HA_MODE_RECOVERY)
val sessionId = 24
val sessionStore = mock[SessionStore]
val session = mockSession(sessionId)
- val sm = new BatchSessionManager(conf, sessionStore, Some(Seq(session)))
+ val sm = new BatchSessionManager(conf, sessionStore, None,
Some(Seq(session)))
sm.get(sessionId) shouldBe defined
sm.shutdown()
verify(session, never).stop()
}
+
+ it("should crate instance of LocalSessionIdGenerator if
livy.server.ha.mode is off") {
Review comment:
Typo: "create".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
