wypoon commented on a change in pull request #296:
URL: https://github.com/apache/incubator-livy/pull/296#discussion_r429364576
##########
File path:
thriftserver/session/src/test/java/org/apache/livy/thriftserver/session/ColumnBufferTest.java
##########
@@ -76,6 +76,8 @@ public void testColumnBuffer() throws Exception {
Encoder<TestBean> encoder = Encoders.bean(TestBean.class);
Dataset<TestBean> ds = spark.createDataset(Arrays.asList(tb), encoder);
+ // In ds, the decimal field will be a
org.apache.spark.sql.types.DecimalType,
Review comment:
Further down, in the for loop iterating over the fields of `ds`, in case
of the `decimal` field, I have a comment that "As decimal maps to
DecimalType(38, 18), we need to change the scale before comparing". I needed to
explain why "decimal maps to DecimalType(38, 18)". I could also move this
comment there, but I explained my thinking behind putting it here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
