----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32844/#review81227 -----------------------------------------------------------
Ship it! src/examples/low_level_scheduler_libprocess.cpp <https://reviews.apache.org/r/32844/#comment131483> Can you fit this on one line by doing `s/event.subscribed().framework_id()/framework.id()/` ? src/examples/low_level_scheduler_pthread.cpp <https://reviews.apache.org/r/32844/#comment131484> Ditto here? src/master/master.cpp <https://reviews.apache.org/r/32844/#comment131485> Do you want this further down, above the second `switch` in this method, since it's general to implementing calls? Whereas this first switch is just for SUBSCRIBE? I guess we don't really need the TODO since we have Unimplemented written in the code :) src/master/master.cpp <https://reviews.apache.org/r/32844/#comment131486> Do we want the same id presence checking here as you had below to drop the call with a more informative message? I'm curious if the set to "" case will become a pain to check everywhere? src/scheduler/scheduler.cpp <https://reviews.apache.org/r/32844/#comment131478> Feel free to tease this change out and commit on its own. No need for review, just might be nice to have a separate bug fix commit? - Ben Mahler On April 22, 2015, 9:42 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32844/ > ----------------------------------------------------------- > > (Updated April 22, 2015, 9:42 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1127 > https://issues.apache.org/jira/browse/MESOS-1127 > > > Repository: mesos > > > Description > ------- > > Instead of REGISTER and REREGISTER we now just have SUBSCRIBE. Similarly, > instead of REGISTERED and REREGISTERED there is only SUBSCRIBED. This will > simplify a scheduler's registration semantics. > > > Diffs > ----- > > include/mesos/scheduler/scheduler.proto > 783a63ad1cc0edd86605d638046fb959cb6e97e8 > src/examples/low_level_scheduler_libprocess.cpp > 63d34eefb60d13fe2b82905c1cec9b762340e997 > src/examples/low_level_scheduler_pthread.cpp > 6d1f938660c02db75bfcbf7c8de0d941cff1920d > src/master/master.cpp f3462d15005e24ab28e8265484b0d3810f21bd47 > src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a > src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657 > > Diff: https://reviews.apache.org/r/32844/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
