> On April 23, 2015, 5:35 p.m., Jie Yu wrote:
> > src/tests/resources_tests.cpp, line 835
> > <https://reviews.apache.org/r/32140/diff/6/?file=939887#file939887line835>
> >
> > Move this to src/tests/mesos.hpp close to createPersistentVolume?
I believe you're referring to `createDiskResource`. I kept
`createReservedResource` close to the tests that use it.
```cpp
static Resource createReservedResource(...) { ... }
// Tests that use createReservedResource...
static Resource createDiskResource(...) { ... }
// Tests that use createDiskResource...
```
Would it be better to pull up the `createDiskResource` to be:
```cpp
static Resource createReservedResource(...) { ... }
static Resource createDiskResource(...) { ... }
// Tests that use createReservedResource...
// Tests that use createDiskResource...
```
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32140/#review81342
-----------------------------------------------------------
On April 22, 2015, 8:36 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32140/
> -----------------------------------------------------------
>
> (Updated April 22, 2015, 8:36 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
>
>
> Bugs: MESOS-2476
> https://issues.apache.org/jira/browse/MESOS-2476
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `Resource::ReservationInfo` was introduced in
> [r32139](https://reviews.apache.org/r/32139). We need to consider it in our
> `Resources` class implementation.
>
> ### `Resources::flatten`
>
> `flatten` is used as the utility function to cross reservation boundaries
> without affecting the given resources. Since the reservation is now specified
> by the (`role`, `reservation`) pair, `flatten` needs to consider
> `ReservationInfo` as well.
>
> ### `Resources::validate`
>
> If `role == "*"`, then `reservation` field must not be set.
>
> ### `Resources` comparators
>
> `operator==`, `addable` and `substractable` need to test for
> `ReservationInfo` as well.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 56affd45e1e71e96ff5778b43271f81b9b9a9e4d
> src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059
> src/tests/mesos.hpp 4294e28f904161b473c0cfa7feea4eaa4e7c97e3
> src/tests/resources_tests.cpp 7e0ad98c3366f647f190363a0e6b576dbfc7d415
>
> Diff: https://reviews.apache.org/r/32140/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>