----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33193/#review81414 -----------------------------------------------------------
Ship it! I'll add the period and get this committed! configure.ac <https://reviews.apache.org/r/33193/#comment131759> s/supported/supported./ - Benjamin Hindman On April 23, 2015, 9:38 p.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33193/ > ----------------------------------------------------------- > > (Updated April 23, 2015, 9:38 p.m.) > > > Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Michael > Park. > > > Repository: mesos > > > Description > ------- > > Warn if g++ < 4.8, C++ standard library is too old > > Not ready for merging. Want the Clang 3.6 patchset to land first: > https://reviews.apache.org/r/32749/ > > A whole bunch more of the C++11 checks can be removed, we can unconditionally > use -std=c++11, among other things with this change. I'm trying to keep the > patch relatively minimal though unless we hit a problem after application and > have to roll it back. > > Explicitly don't check clang version number, since extracting it is hard (OS > X clang behaves differently than Linux clang), and 'clang -dumpversion' > always reports 4.2.1 for compatibility with some random tools... > > > Diffs > ----- > > configure.ac 7f9e52916b9d78f2bbff9d6ed9871444a0fda629 > > Diff: https://reviews.apache.org/r/33193/diff/ > > > Testing > ------- > > Basic hand testing gcc 4.9.2, gcc 4.4.7, clang 3.6 all on Windows > > > Thanks, > > Cody Maloney > >
