> On April 1, 2015, 6:03 p.m., Ian Downes wrote:
> > src/slave/flags.hpp, lines 386-389
> > <https://reviews.apache.org/r/32660/diff/2/?file=911856#file911856line386>
> >
> >     we've added flags only for potentially expensive queries; do you expect 
> > these to be?
> >     
> >     also, the name is too generic ;-)

Overhead is small so I have removed the flag.


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32660/#review78546
-----------------------------------------------------------


On April 1, 2015, 3:45 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32660/
> -----------------------------------------------------------
> 
> (Updated April 1, 2015, 3:45 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.
> 
> 
> Bugs: mesos-2332
>     https://issues.apache.org/jira/browse/mesos-2332
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Report network isolator statistics on a per container basis (MESOS-2332)
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 3c592d5ab3092ecbeddfaff95e0c1addc3ac58f8 
>   src/slave/containerizer/isolators/network/port_mapping.hpp 
> 33837b4662959a003c8f38d1e786c6615287a4ff 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> e691d463515084518c94cdec3fbdf37be4a72977 
>   src/slave/flags.hpp 3da71afad38ae41adefab979dbed2ae0b10a98ef 
> 
> Diff: https://reviews.apache.org/r/32660/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>

Reply via email to