> On April 15, 2015, 5:36 p.m., Alexander Rukletsov wrote: > > src/common/resources.cpp, lines 455-464 > > <https://reviews.apache.org/r/32140/diff/5/?file=920081#file920081line455> > > > > Agree with Jie, I spent some time trying to understand what's going on > > here and what the implications are. > > > > * `.has_reservation()` means a resource is dynamically reserved; > > * `.role() != "*"` means a resource is reserved for a role. > > > > Currently we do not allow reservations for "*" role, this is validated > > above. But what is the semantics of `isUnreserved()` function? It used to > > be "a resource belongs to a default role". Let's write a comment to > > document our intention here, mentioning all assumptions that we currently > > make.
I've added the valid states of the (role, reservation) pair which I think help in reasoning through the logic of the predicates. Do you think this is sufficient? - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32140/#review80201 ----------------------------------------------------------- On April 27, 2015, 5:28 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32140/ > ----------------------------------------------------------- > > (Updated April 27, 2015, 5:28 p.m.) > > > Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu. > > > Bugs: MESOS-2476 > https://issues.apache.org/jira/browse/MESOS-2476 > > > Repository: mesos > > > Description > ------- > > `Resource::ReservationInfo` was introduced in > [r32139](https://reviews.apache.org/r/32139). We need to consider it in our > `Resources` class implementation. > > ### `Resources::flatten` > > `flatten` is used as the utility function to cross reservation boundaries > without affecting the given resources. Since the reservation is now specified > by the (`role`, `reservation`) pair, `flatten` needs to consider > `ReservationInfo` as well. > > ### `Resources::validate` > > If `role == "*"`, then `reservation` field must not be set. > > ### `Resources` comparators > > `operator==`, `addable` and `substractable` need to test for > `ReservationInfo` as well. > > > Diffs > ----- > > include/mesos/resources.hpp 56affd45e1e71e96ff5778b43271f81b9b9a9e4d > src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059 > src/tests/mesos.hpp 19db71217f0a3f1ab17a6fd4408f8251410d731d > src/tests/resources_tests.cpp 7e0ad98c3366f647f190363a0e6b576dbfc7d415 > > Diff: https://reviews.apache.org/r/32140/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
