-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33572/#review81881
-----------------------------------------------------------

Ship it!


Keeping `union` confined to library implementation sounds good. On a related 
note, we might benefit from a more generalized `Either<T1, T2, T3, ...>` type 
(in the same spirit as boost's variant). For example, `http::Response`. Also, 
we have places where we use inheritance to acheive multiple implementations 
(e.g. process::Event), but the pointer indirection sometimes gets in the way 
(e.g. cannot copy by value). Curious to know your thoughts on this.

- Ben Mahler


On April 26, 2015, 8:26 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33572/
> -----------------------------------------------------------
> 
> (Updated April 26, 2015, 8:26 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Joris Van Remoortere, Michael Park, and 
> Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary. We'll be updating 'Option', 'Result', etc with this for 
> performance improvements soon too!
> 
> 
> Diffs
> -----
> 
>   docs/mesos-c++-style-guide.md fe98f90ad0b0f5dd38af97e85062e90cee8de99e 
> 
> Diff: https://reviews.apache.org/r/33572/diff/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Reply via email to