> On April 28, 2015, 12:15 a.m., Alexander Rukletsov wrote:
> > Could you please add a period in summary? Also, don't we need license 
> > snippet at the top of each file?

Both fixed. thx!


- Bernd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32108/#review81783
-----------------------------------------------------------


On April 27, 2015, 6:44 p.m., Bernd Mathiske wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32108/
> -----------------------------------------------------------
> 
> (Updated April 27, 2015, 6:44 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Readability source code now has a Makefile that is generated by bootstrap and 
> configure. "cd build/readability; make" compiles the sources in 
> "readability/". No linking occurs. This is just to ensure that we have 
> syntactially correct and type-checked example files.
> 
> Slightly rearranged the content of naming_*.cpp and broke out an extra file 
> for whitespace issues.
> 
> Replaces:
> https://reviews.apache.org/r/31990/
> https://reviews.apache.org/r/31992/
> 
> 
> Diffs
> -----
> 
>   configure.ac 589ae97d0432370b462576cd1985544564893999 
>   readability/Makefile.am PRE-CREATION 
>   readability/README.md PRE-CREATION 
>   readability/naming_comments.cpp PRE-CREATION 
>   readability/naming_review.cpp PRE-CREATION 
>   readability/whitespace_comments.cpp PRE-CREATION 
>   readability/whitespace_review.cpp PRE-CREATION 
>   support/hooks/pre-commit 09ce57816b4aa953fea6bd9574223626edb23699 
> 
> Diff: https://reviews.apache.org/r/32108/diff/
> 
> 
> Testing
> -------
> 
> cd build/readability; make
> 
> Also observed that the pre-commit hook does this as well.
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>

Reply via email to