> On May 1, 2015, 11:14 p.m., Bernd Mathiske wrote: > > src/slave/containerizer/docker.hpp, line 454 > > <https://reviews.apache.org/r/29889/diff/8/?file=946143#file946143line454> > > > > This is a good place to explain the whole picture what each > > override<...> is, what it's purpose is and how it gets used. However, if > > this is deemed a generic facility, then some of the use sites need to be > > upgraded with docker-specific scenario descriptions.
I got rid of override completely now. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29889/#review82287 ----------------------------------------------------------- On May 1, 2015, 9:43 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29889/ > ----------------------------------------------------------- > > (Updated May 1, 2015, 9:43 p.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Till > Toenshoff. > > > Bugs: MESOS-2115 > https://issues.apache.org/jira/browse/MESOS-2115 > > > Repository: mesos > > > Description > ------- > > This is a one mega patch and contains many reviews that's already on rb. > > This review is not meant to be merged, only provided for easier review. > > > Diffs > ----- > > Dockerfile 35abf25 > docs/configuration.md 54c4e31 > docs/docker-containerizer.md a5438b7 > src/Makefile.am 93c7c8a > src/docker/docker.hpp 3ebbc1f > src/docker/docker.cpp 3a485a2 > src/docker/executor.cpp PRE-CREATION > src/slave/constants.hpp fd1c1ab > src/slave/constants.cpp 2a99b11 > src/slave/containerizer/docker.hpp b25ec55 > src/slave/containerizer/docker.cpp f9fc89a > src/slave/flags.hpp d3b1ce1 > src/slave/flags.cpp d0932b0 > src/tests/docker_containerizer_tests.cpp c9d66b3 > > Diff: https://reviews.apache.org/r/29889/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >