> On April 28, 2015, 2:08 a.m., Ben Mahler wrote:
> > docs/mesos-c++-style-guide.md, lines 206-208
> > <https://reviews.apache.org/r/33558/diff/3/?file=942044#file942044line206>
> >
> >     What does it mean to pass a lambda to `socket.send`? Doesn't look like 
> > this is functionality provided on the existing socket we have, and I'm not 
> > sure what this would do.. provide a functor of the data?
> 
> Michael Park wrote:
>     As this review is about style, I myself didn't dig into the validity of 
> this example all that much. But perhaps we should find a more realistic 
> example.
> 
> Benjamin Hindman wrote:
>     I changed them all to 'instance.method'.

Thanks! Fixed one that was missed.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33558/#review81769
-----------------------------------------------------------


On April 28, 2015, 5:33 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33558/
> -----------------------------------------------------------
> 
> (Updated April 28, 2015, 5:33 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Joris Van Remoortere, Michael Park, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-2669
>     https://issues.apache.org/jira/browse/MESOS-2669
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary. Note that there will be a follow up review which enacts this 
> style in the code base.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-c++-style-guide.md fe98f90ad0b0f5dd38af97e85062e90cee8de99e 
> 
> Diff: https://reviews.apache.org/r/33558/diff/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Reply via email to