-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33865/#review82594
-----------------------------------------------------------


Patch looks great!

Reviews applied: [33865]

All tests passed.

- Mesos ReviewBot


On May 5, 2015, 9:13 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33865/
> -----------------------------------------------------------
> 
> (Updated May 5, 2015, 9:13 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-2691
>     https://issues.apache.org/jira/browse/MESOS-2691
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> RevocableInfo currently supports OVERSUBSCRIBED resources. In the future it 
> can be easily extended to use other types of revocable reosurces (e.g., 
> resources allocated to other roles).
> 
> Disabled the ability to use revocable resources for reservation or 
> persistence because the semantics seem weird. We can enable it in the future 
> if there is a use case for that.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto db4fc8c001dd68bc3b9ca83650170c4f26db18c7 
>   src/common/resources.cpp 235930ff2dbb3ea49a3a0696dc070f2bd56fba4b 
>   src/tests/resources_tests.cpp a7ec59ea217ad71f7d1e93ca6039d5b2491b3237 
> 
> Diff: https://reviews.apache.org/r/33865/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Reply via email to