-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33643/#review82624
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp
<https://reviews.apache.org/r/33643/#comment133391>

    Any reason we can't do this as a function with a static in it? Solves the 
destruction order issues, doesn't leak, doesn't require the constant reference.


- Cody Maloney


On May 5, 2015, 9:50 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33643/
> -----------------------------------------------------------
> 
> (Updated May 5, 2015, 9:50 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 
> d2b74393b7c4b65477698d9c810dfe3c8673c2ab 
> 
> Diff: https://reviews.apache.org/r/33643/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Reply via email to