----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33490/#review82867 -----------------------------------------------------------
Hm, I looked at MESOS-2633, that's only about moving implementation out? Could we get some more context on this change? What motivated it? Is there a bug? When can it occur? What happens if it does? - Ben Mahler On May 7, 2015, 8:26 a.m., Marco Massenzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33490/ > ----------------------------------------------------------- > > (Updated May 7, 2015, 8:26 a.m.) > > > Review request for mesos, Adam B and Joris Van Remoortere. > > > Bugs: MESOS-2633 > https://issues.apache.org/jira/browse/MESOS-2633 > > > Repository: mesos > > > Description > ------- > > In Framework::addCompletedTask(const Task& task) we did not check > for duplicated tasks, so they could be added more than once. > > A simple check has now been added (there still is the issue > of whether the `operator ==` on `Task` is too strict, so as > never to cause a match). > > > Diffs > ----- > > src/master/framework.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/33490/diff/ > > > Testing > ------- > > buildbot make check pass > http://build.mesosphere.com:5555/builders/dev_test/builds/13 > > > Thanks, > > Marco Massenzio > >
