-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33275/#review82874
-----------------------------------------------------------

Ship it!


Short bechmark (for the combined effort of removing temporaries) confirming 
non-noticable performance penalty og these changes would be cool.

- Joerg Schad


On April 22, 2015, 6:11 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33275/
> -----------------------------------------------------------
> 
> (Updated April 22, 2015, 6:11 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Cody Maloney, Joerg Schad, Michael 
> Park, and Till Toenshoff.
> 
> 
> Bugs: MESOS-2630
>     https://issues.apache.org/jira/browse/MESOS-2630
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 
> 37e007e9ee3010d9aacf2de6254abb75b716412d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> fb383b463a99924483634eebf22bf34de318f920 
>   3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 
> e0b60fe2766f0cb5681b5c55c5ff4ed61cd6a4a7 
>   3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
> 334c898906018be6e663f53815abbe047806b95c 
>   3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp 
> ecda6a941077b3e4f9585674b0b5d00d35c5aa1a 
>   3rdparty/libprocess/3rdparty/stout/include/stout/multimap.hpp 
> 9714ba0668e5bd91c215eaf3c3e8728feb41887f 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 02db3c587e3f9a40282405e9496bde30e251f8bb 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp 
> 7a5573be8d8be537e5fd85b86e322fd5765c54ab 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp 
> 7d172494444cf1d14e9344112dd7fef7230c2ad8 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/pstree.hpp 
> e7fe077f763518680ba13d609dba9ea26950210d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/shell.hpp 
> 6728ad8109dfd5e490c0f63684fbf05d0e1fd1b2 
>   3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 
> 46b79bc5c11cb1878ffccb4c0c8bb8a49ee9832d 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> 343f95be7f316170b37c9358627f3c2090f0e29e 
> 
> Diff: https://reviews.apache.org/r/33275/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Reply via email to