-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33918/#review82905
-----------------------------------------------------------



src/slave/resources_estimator.hpp
<https://reviews.apache.org/r/33918/#comment133740>

    Interesting, what will go in here? I have a hard time seeing a general 
"Mesos"ResourcesEstimator evolve. It seems like there might be a number of 
different estimators included in Mesos that folks can choose from. For example, 
to disable oversubscription, we could just use a no-op estimator, yes? Maybe 
that's what we should implement here? An EmptyResourceEstimator, or 
NoopResourceEstimator?
    
    That seems like an easy way to disable oversubscription? (ignoring whether 
disabling means killing revocable containers)
    
    Overall this feels similar to how we have the Allocator interface, a DRF 
allocator implementation and potentially others (note we didn't call it the 
MesosAllocator :)). Containerizer is another case where we have a pluggable 
isolation based containerizer, a docker containerizer, and potentially others 
to choose from.
    
    Just some food for thought. :)


- Ben Mahler


On May 6, 2015, 10:35 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33918/
> -----------------------------------------------------------
> 
> (Updated May 6, 2015, 10:35 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Joris Van Remoortere, Niklas Nielsen, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-2649
>     https://issues.apache.org/jira/browse/MESOS-2649
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added resources estimator abstraction for oversubscription.
> 
> This patch defines the interface of the resources estimator and creates a 
> default stub implementation.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/resources_estimator.hpp PRE-CREATION 
>   src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b 
>   src/slave/resources_estimator.hpp PRE-CREATION 
>   src/slave/resources_estimator.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33918/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to