> On May 7, 2015, 4:57 p.m., Niklas Nielsen wrote: > > src/slave/resources_estimator.cpp, lines 59-60 > > <https://reviews.apache.org/r/33918/diff/1/?file=951653#file951653line59> > > > > Shouldn't we be able to start the process in the constructor and > > forward initialize() to the process here?
'initialize' will take a resource monitor pointer in the near future, and as far as I know, we don't support initialize a module instance with a pointer. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33918/#review82829 ----------------------------------------------------------- On May 6, 2015, 10:35 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33918/ > ----------------------------------------------------------- > > (Updated May 6, 2015, 10:35 p.m.) > > > Review request for mesos, Ben Mahler, Joris Van Remoortere, Niklas Nielsen, > and Vinod Kone. > > > Bugs: MESOS-2649 > https://issues.apache.org/jira/browse/MESOS-2649 > > > Repository: mesos > > > Description > ------- > > Added resources estimator abstraction for oversubscription. > > This patch defines the interface of the resources estimator and creates a > default stub implementation. > > > Diffs > ----- > > include/mesos/slave/resources_estimator.hpp PRE-CREATION > src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b > src/slave/resources_estimator.hpp PRE-CREATION > src/slave/resources_estimator.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/33918/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
