----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33718/#review83074 -----------------------------------------------------------
docs/modules.md <https://reviews.apache.org/r/33718/#comment133941> I would like to propose using two terms for making clear the specific roles of those flags. `--modules` is there for __introducing__ any module (name, location and parameters) to mesos. `--hooks` is there for __selecting__ a specific module as a hooks module. Hence my clumpsy attempt to reword: For introducing any module to mesos, you need to specify its name via the `--modules` flag configuration. For selecting that module as a hook module, you will have to additionally specify it via the `--hooks` flag. docs/modules.md <https://reviews.apache.org/r/33718/#comment133942> s/5050/<PORT>/ s/--work_dir=s\/work// - Till Toenshoff On May 7, 2015, 8:40 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33718/ > ----------------------------------------------------------- > > (Updated May 7, 2015, 8:40 p.m.) > > > Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Till > Toenshoff. > > > Bugs: MESOS-2680 > https://issues.apache.org/jira/browse/MESOS-2680 > > > Repository: mesos > > > Description > ------- > > Mentions necessary flags and adds a usage example. > > > Diffs > ----- > > docs/modules.md a8b471541cdfa584eeb89fbe96643f93c712cfd4 > > Diff: https://reviews.apache.org/r/33718/diff/ > > > Testing > ------- > > none: docs update. > > @Adam: as a native speaker, do you mind checking the language? > > > Thanks, > > Alexander Rukletsov > >