-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29748/#review83313
-----------------------------------------------------------

Ship it!



src/tests/reservation_tests.cpp
<https://reviews.apache.org/r/29748/#comment134249>

    YOu do need a snake_case checker:)



src/tests/reservation_tests.cpp
<https://reviews.apache.org/r/29748/#comment134251>

    Hum, have the following 3 tests already been captured in 
ReserveOperationValidationTest?



src/tests/reservation_tests.cpp
<https://reviews.apache.org/r/29748/#comment134256>

    2 lines apart between two top level declarations. Please make sure this is 
the case in this file.


- Jie Yu


On May 9, 2015, 4:38 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29748/
> -----------------------------------------------------------
> 
> (Updated May 9, 2015, 4:38 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
> 
> 
> Bugs: MESOS-2489
>     https://issues.apache.org/jira/browse/MESOS-2489
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b 
>   src/tests/reservation_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29748/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Reply via email to