> On May 11, 2015, 10:47 p.m., Ben Mahler wrote:
> > Thanks! Could you split the patch between the implementation and the test? 
> > The implementation looks pretty good so would like to give a ship it on 
> > that before I review the test. Much appreciated :)

Hi, @bmahler. I update the patch and split them. The test part: 
https://reviews.apache.org/r/34068/ .
And feel very sorry that no follow the style guide before, could you help me 
review again? Thank you very much.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33792/#review83303
-----------------------------------------------------------


On May 12, 2015, 12:55 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33792/
> -----------------------------------------------------------
> 
> (Updated May 12, 2015, 12:55 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Ben Mahler.
> 
> 
> Bugs: MESOS-328
>     https://issues.apache.org/jira/browse/MESOS-328
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Extend hashmap to support custom equality and hash
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp 
> 24dc369ec271ec2f35449e6ccf49c5b829ca6ce8 
> 
> Diff: https://reviews.apache.org/r/33792/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to