----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33154/#review83463 -----------------------------------------------------------
LGTM. Can you add a comment on removeSlave() on why it takes a const ref of 'reason' per Alex's comments? - Vinod Kone On May 12, 2015, 2:51 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33154/ > ----------------------------------------------------------- > > (Updated May 12, 2015, 2:51 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2485 > https://issues.apache.org/jira/browse/MESOS-2485 > > > Repository: mesos > > > Description > ------- > > See [MESOS-2485](https://issues.apache.org/jira/browse/MESOS-2485). > > > Diffs > ----- > > include/mesos/mesos.proto db4fc8c001dd68bc3b9ca83650170c4f26db18c7 > src/master/master.hpp af41216f4a8b81e58916c607a843965aeb4dfb5e > src/master/master.cpp ec32cd655c5a4fded0b682b320a6e0867e4e6468 > src/master/metrics.hpp ee3982e38f23b0dcf92d6b1c39b650c3582c16a2 > src/master/metrics.cpp 973f0517400786fb16f86914d1d077c88965c9da > > Diff: https://reviews.apache.org/r/33154/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
