> On April 16, 2015, 11:04 p.m., Vinod Kone wrote:
> > src/tests/master_tests.cpp, lines 1725-1731
> > <https://reviews.apache.org/r/33155/diff/1/?file=926682#file926682line1725>
> >
> >     I'm a bit confused on how slave's lifetime affects the metrics 
> > collection on master endpoint?
> 
> Ben Mahler wrote:
>     There is no "master endpoint" for metrics, only the shared 
> /metrics/snapshot endpoint. So the slave's leftover metrics after 
> finalization will block the metrics collection per the TODO. Does this make 
> sense? If not let me know we can come up with a better TODO!

Ah, my bad, I misdiagnosed this originally. This was because the 
"PartitionTest.PartitionedSlave" did not stop the slave, which means that its 
metrics weren't getting removed. So I've uncommented all of the tests now! 
Thanks for following up on this.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33155/#review80397
-----------------------------------------------------------


On April 14, 2015, 1:46 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33155/
> -----------------------------------------------------------
> 
> (Updated April 14, 2015, 1:46 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2485
>     https://issues.apache.org/jira/browse/MESOS-2485
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> I updated the existing tests to validate the metrics. However, it blocks the 
> tests due to the slave metrics never getting satisfied. Added a TODO.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 32b1e9bb58d8046e5363fafe2ab8f662b6c9a666 
>   src/tests/partition_tests.cpp 1018e479a77a6b533f2dd392fedbdccb80e3ac1f 
>   src/tests/slave_tests.cpp b826000e0a4221690f956ea51f49ad4c99d5e188 
> 
> Diff: https://reviews.apache.org/r/33155/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Reply via email to