-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33155/#review83538
-----------------------------------------------------------


Patch looks great!

Reviews applied: [33152, 33153, 33154, 33155]

All tests passed.

- Mesos ReviewBot


On May 12, 2015, 11:32 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33155/
> -----------------------------------------------------------
> 
> (Updated May 12, 2015, 11:32 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2485
>     https://issues.apache.org/jira/browse/MESOS-2485
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> I updated the existing tests to validate the metrics. However, it blocks the 
> tests due to the slave metrics never getting satisfied. Added a TODO.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 75ffadae64ece4e3ff53abeefa5f6e8e3690d402 
>   src/tests/partition_tests.cpp 1018e479a77a6b533f2dd392fedbdccb80e3ac1f 
>   src/tests/slave_tests.cpp 04e79ec061e767a82d40242be7884967942c50b6 
> 
> Diff: https://reviews.apache.org/r/33155/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Reply via email to