----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34135/#review83558 -----------------------------------------------------------
src/slave/containerizer/isolators/filesystem/linux.cpp <https://reviews.apache.org/r/34135/#comment134561> I'm still learning our lambda style rules, but seems like we don't put a space in between [] and () src/slave/containerizer/isolators/filesystem/linux.cpp <https://reviews.apache.org/r/34135/#comment134562> Somehow this wrapping reads a bit funny to me, I don't think we usually line break like this? Don't we either put them all on seperate lines, or as it fits here all the params in one line? Just a nit. src/slave/containerizer/isolators/filesystem/linux.cpp <https://reviews.apache.org/r/34135/#comment134564> s/directory//work directory/g src/slave/containerizer/isolators/filesystem/linux.cpp <https://reviews.apache.org/r/34135/#comment134563> What's the rationale here? Leave a comment perhaps? src/slave/containerizer/isolators/filesystem/linux.cpp <https://reviews.apache.org/r/34135/#comment134565> Same here src/slave/containerizer/isolators/filesystem/linux.cpp <https://reviews.apache.org/r/34135/#comment134566> if using the host's filesystem src/slave/containerizer/isolators/filesystem/linux.cpp <https://reviews.apache.org/r/34135/#comment134567> hmm, looks like the extra slash is intentinoal then? src/slave/containerizer/isolators/filesystem/linux.cpp <https://reviews.apache.org/r/34135/#comment134568> I think we don't put space between [] and (). src/slave/containerizer/isolators/filesystem/linux.cpp <https://reviews.apache.org/r/34135/#comment134569> ditto src/slave/containerizer/isolators/filesystem/linux.cpp <https://reviews.apache.org/r/34135/#comment134570> Log the umount error? src/slave/containerizer/isolators/filesystem/linux.cpp <https://reviews.apache.org/r/34135/#comment134572> log the mount error? - Timothy Chen On May 13, 2015, 12:47 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34135/ > ----------------------------------------------------------- > > (Updated May 13, 2015, 12:47 a.m.) > > > Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Moved code from Mesos Containerizer to filesystem isolators > - filesystem/posix (symlinks, doesn't support container rootfs) > - filesystem/linux (bind mounts, does support container rootfs) > > The filesystem/posix isolator will be automatically included if no > filesystem/ isolator is specified. > > > Diffs > ----- > > src/Makefile.am 14bc976a7b6a656fb58085484d25c3de3cf0f693 > src/slave/containerizer/isolators/filesystem/linux.hpp PRE-CREATION > src/slave/containerizer/isolators/filesystem/linux.cpp PRE-CREATION > src/slave/containerizer/isolators/filesystem/posix.hpp PRE-CREATION > src/slave/containerizer/isolators/filesystem/posix.cpp PRE-CREATION > src/slave/containerizer/linux_launcher.cpp > b9e22e3c70bed0c29e2ca8632411789d33f779a8 > src/slave/containerizer/mesos/containerizer.cpp > b644b9c74bc23cf78c0a53284544be6cdaef2f8a > > Diff: https://reviews.apache.org/r/34135/diff/ > > > Testing > ------- > > existing persistent volumes tests. > > > Thanks, > > Ian Downes > >
