----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/#review83678 -----------------------------------------------------------
docs/reservation.md <https://reviews.apache.org/r/32982/#comment134702> Simpler: No breaking changes are introduced with dynamic reservation, ... ---- Suggestion: singular "reservation" here. Either this or make the mention in line 7 plural as well. docs/reservation.md <https://reviews.apache.org/r/32982/#comment134703> s/manage the/manage There are no definite reservations this sentence refers to. docs/reservation.md <https://reviews.apache.org/r/32982/#comment134704> s/we'll/we will docs/reservation.md <https://reviews.apache.org/r/32982/#comment134706> s/we'll/we will and please check other places Suggestion: avoid colloquial style in documentation. docs/reservation.md <https://reviews.apache.org/r/32982/#comment134708> This sentence does not strictly add any information. It is more likely confusing. What does it mean to "convert" a resource? I suppose we are merely accounting for them here, not physically affecting the resources themselves, right? Suggestion: The Mesos master will take the requested reservation into account. docs/reservation.md <https://reviews.apache.org/r/32982/#comment134710> Same as the above sentence. docs/reservation.md <https://reviews.apache.org/r/32982/#comment134711> "state of the recources" - what does this mean? Suggestion: "resource specifications" docs/reservation.md <https://reviews.apache.org/r/32982/#comment134712> s/an/a docs/reservation.md <https://reviews.apache.org/r/32982/#comment134713> Isn't this the exact same offer as above? Can we simply reference it instead of repeating it? docs/reservation.md <https://reviews.apache.org/r/32982/#comment134714> Even if we repeat the offer from way above here, we may want to mention that it is exactly the same again. - Bernd Mathiske On May 13, 2015, 3:15 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32982/ > ----------------------------------------------------------- > > (Updated May 13, 2015, 3:15 p.m.) > > > Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-2205 > https://issues.apache.org/jira/browse/MESOS-2205 > > > Repository: mesos > > > Description > ------- > > See summary. > > NOTE: The framework API should be reviewed thoroughly at this point since > those have been implemented and landed. > The master API endpoints however are still in development and therefore > the state reflected in this patch is incomplete. (e.g. what HTTP code do we > return on failures?) > I'll update the guide to accurately reflect the master endpoints as it > gets more solified. > The purpose of including it was/is to get initial feedback on how it > generally works. > > > Diffs > ----- > > docs/reservation.md PRE-CREATION > > Diff: https://reviews.apache.org/r/32982/diff/ > > > Testing > ------- > > Documentation. > > > Thanks, > > Michael Park > >
