----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33514/#review83764 -----------------------------------------------------------
Patch looks great! Reviews applied: [33513, 33514] All tests passed. - Mesos ReviewBot On May 14, 2015, 1:23 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33514/ > ----------------------------------------------------------- > > (Updated May 14, 2015, 1:23 p.m.) > > > Review request for mesos, Kapil Arya, Niklas Nielsen, and Till Toenshoff. > > > Bugs: MESOS-2597 > https://issues.apache.org/jira/browse/MESOS-2597 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/flags.hpp 996cf38c88f9718e55e88d6e906b5e3d1989478a > src/master/flags.cpp 5798989d3f135978ec3d5f714b1cd8d84180fc90 > src/master/main.cpp 18f8c3178459da0cbf23a1817ec49cd9d3998bfd > > Diff: https://reviews.apache.org/r/33514/diff/ > > > Testing > ------- > > make check (Mac OS 10.9.5, CentOS 7.0) > > Checked the whole pipeline works with a modularized allocator. The allocator > is HierarchicalDRF packed into a library: > https://github.com/rukletsov/mesos-modules/tree/master/external-allocator > > Master and slave have been pointed to an allocator module: > ``` > ./bin/mesos-master.sh --work_dir=m/work > --modules=file://<path>/external-allocator.json > --allocator=ExternalAllocatorModule > ./bin/mesos-slave.sh --master=<master-ip> --work_dir=s/work > ``` > > Slave successfully registers, its resources are offered to a simple task: > ``` > ./src/mesos-execute --command="sleep 1" --master=<master-ip> --name=alloc-test > ``` > > > Thanks, > > Alexander Rukletsov > >
