-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34310/#review84039
-----------------------------------------------------------


Hi Ian,

I'm wondering about the `Note` regarding only setting the scheduling policy to 
IDLE if the initial resources are revocable. I think this exposes many 
scenarios where the isolator will seem `enabled` to the operator, but won't 
actually be isolating correctly.
I don't think it is uncommon to launch an executor with non-revocable 
resources, and then later launch BE tasks with revocable resources. This 
pattern would always lead to the isolator being in-effective right?

I am not super familiar with the rules around the isolators, but why can we not 
adjust the policy within the update() call as opposed to in the isolate() 
function?


src/slave/containerizer/isolators/cgroups/cpushare.cpp
<https://reviews.apache.org/r/34310/#comment135169>

    Do you actually use anything provided by this header explicitly in this 
file? I don't think we need to include it again here.



src/slave/containerizer/isolators/cgroups/cpushare.cpp
<https://reviews.apache.org/r/34310/#comment135170>

    Should we add the container id to this error message?



src/slave/containerizer/isolators/cgroups/cpushare.cpp
<https://reviews.apache.org/r/34310/#comment135171>

    If this succeeds, should we log an INFO message? I think this is a 
significant enough system change to warrant some debugging info.


- Joris Van Remoortere


On May 16, 2015, 1:14 a.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34310/
> -----------------------------------------------------------
> 
> (Updated May 16, 2015, 1:14 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Niklas Nielsen, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-2652
>     https://issues.apache.org/jira/browse/MESOS-2652
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Use IDLE scheduling for revocable CPU in cgroups isolator.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/cgroups/cpushare.hpp 
> ff4a9dbdb1b655e71bf87dcee8fe62433d396f52 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 
> 6a5b2b5c6e2844fe1a10815956569194b6f56681 
> 
> Diff: https://reviews.apache.org/r/34310/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Reply via email to